Skip to content
Snippets Groups Projects
  1. Jan 16, 2010
  2. Jan 15, 2010
  3. Jan 12, 2010
    • Shawn Pearce's avatar
      Add JUnit tests for HTTP transport · f5eb0d93
      Shawn Pearce authored
      
      No Eclipse support for this project is provided, because the
      Jetty project does not publish a complete P2 repository.
      
      Change-Id: Ic5fe2e79bb216e36920fd4a70ec15dd6ccfd1468
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      f5eb0d93
    • Shawn Pearce's avatar
      Download HEAD by itself if not in info/refs · d5bc8be7
      Shawn Pearce authored
      
      The dumb HTTP transport needs to download the HEAD ref and
      resolve it manually if HEAD does not appear in info/refs.
      
      Its typically for it to not be in the info/refs file.
      
      Change-Id: Ie2a58fdfacfeee530b10edb433b8f98c85568585
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      d5bc8be7
    • Shawn Pearce's avatar
      client side smart HTTP · 8c836c6f
      Shawn Pearce authored
      
      During fetch over http:// clients now try to take advantage of
      the info/refs?service=git-upload-pack URL to determine if the
      remote side will support a standard upload-pack command stream.
      If so each block of 32 have lines is sent in one POST request,
      prefixed by all of the 'want' lines and any previously discovered
      common bases as 'have' lines.
      
      During push over http:// clients now try to take advantage of
      the info/refs?service=git-receive-pack URL to determine if the
      remote side will support a standard receive-pack command stream.
      If so, commands are sent along with their pack in a single HTTP
      POST request.
      
      Bug: 291002
      Change-Id: I8c69b16ac15c442e1a4c3bd60b4ea1a47882b851
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      8c836c6f
    • Shawn Pearce's avatar
      server side: smart fetch over HTTP · 2e521446
      Shawn Pearce authored
      
      Clients can request smart fetch support by examining the info/refs URL
      with the service parameter set to the magic git-upload-pack string:
      
        GET /$GIT_DIR/info/refs?service=git-upload-pack HTTP/1.1
      
      The response is formatted with the upload pack capabilities, using
      the standard packet line formatter.  A special header line is put
      in front of the standard upload-pack advertisement to let clients
      know the service was recognized and is supported.
      
      If the requested service is disabled an authorization status code is
      returned, allowing the user agent to retry once they have obtained
      credentials from a human, in case authentication is required by
      the configured UploadPackFactory implementation.
      
      Change-Id: Ib0f1a458c88b4b5509b0f882f55f83f5752bc57a
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      2e521446
    • Shawn Pearce's avatar
      server side: smart push over HTTP · 81fea92e
      Shawn Pearce authored
      
      Clients can request smart push support by examining the info/refs URL
      with the service parameter set to the magic git-receive-pack string:
      
        GET /$GIT_DIR/info/refs?service=git-receive-pack HTTP/1.1
      
      The response is formatted with the receive pack capabilities, using
      the standard packet line formatter.  A special header block is put
      in front of the standard receive-pack advertisement to let clients
      know the service was recognized and is supported.
      
      If the requested service is disabled an authorization status code is
      returned, allowing the user agent to retry once they have obtained
      credentials from a human, in case authentication is required by
      the configured ReceivePackFactory implementation.
      
      Change-Id: Ie4f6e0c7b68a68ec4b7cdd5072f91dd406210d4f
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      81fea92e
    • Shawn Pearce's avatar
      Simple dumb HTTP server for Git · 5e33a1de
      Shawn Pearce authored
      
      This is a simple HTTP server that provides the minimum server side
      support required for dumb (non-git aware) transport clients.
      
      We produce the info/refs and objects/info/packs file on the fly
      from the local repository state, but otherwise serve data as raw
      files from the on-disk structure.
      
      In the future we could better optimize the FileSender class and the
      servlets that use it to take advantage of direct file to network
      APIs in more advanced servlet containers like Jetty.
      
      Our glue package borrows the idea of a micro embedded DSL from
      Google Guice and uses it to configure a collection of Filters
      and HttpServlets, all of which are matched against requests using
      regular expressions.  If a subgroup exists in the pattern, it is
      extracted and used for the path info component of the request.
      
      Change-Id: Ia0f1a425d07d035e344ae54faf8aeb04763e7487
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      5e33a1de
    • Shawn Pearce's avatar
      Expose PacketLineOut for reuse outside of the transport package · 71b34847
      Shawn Pearce authored
      
      Change-Id: Iaa331a476e28cf2880df5607de36bc9f67d041df
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      71b34847
    • Shawn Pearce's avatar
      Expose RefAdvertiser for reuse outside of the transport package · 7ed68054
      Shawn Pearce authored
      
      By making this class and its methods public, and the actual writing
      abstract, we can reuse this code for other formats like writing an
      info/refs file for HTTP transports.
      
      Change-Id: Id0e349c30a0f5a8c1527e0e7383b80243819d9c5
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      7ed68054
    • Shawn Pearce's avatar
      Teach UploadPack how to use an RPC style interface · e187618b
      Shawn Pearce authored
      
      If biDirectionalPipe is false UploadPack does not start out with
      the advertisement but instead assumes it should read one block of
      want/have lines, process that, and write the ACK/NAKs out.
      
      This means it only is doing one read through the input followed by
      one write to the output, which fits with the HTTP request processing
      model, and any other type of RPC system.
      
      Change-Id: Ia9f7c46ee556f996367180f15d2caa8572cdd59f
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      e187618b
    • Shawn Pearce's avatar
      Teach ReceivePack how to use an RPC style interface · 2a5c8cb4
      Shawn Pearce authored
      
      If biDirectionalPipe is false ReceivePack does not start out with the
      advertisement but instead assumes it should read the command set once,
      process that, and write the status report out.  This means it only is
      doing one read through the input followed by one write to the output,
      which fits with the HTTP request processing model, and any other type
      of RPC system... assuming that the payload for input can be a very big
      entity like the command stream followed by the pack file.
      
      Change-Id: I6f31f6537a3b7498803a8a54e10b0622105718c1
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      2a5c8cb4
    • Shawn Pearce's avatar
      Refactor TemporaryBuffer to support reuse in other contexts · 3f8fdc03
      Shawn Pearce authored
      
      Later we are going to add support for smart HTTP, which requires us to
      buffer at least some of the request created by a client before we ship
      it to the server.  For many requests, we can fit it completely into a
      1 MiB buffer, but if it doesn't we can drop back to using the chunked
      transfer encoding to send an unknown stream length.
      
      Rather than recoding the block based memory buffer, we refactor the
      local file overflow strategy into a subclass, allowing the HTTP client
      code to replace this portion of the logic with its own approach to
      start the chunked encoding request.
      
      Change-Id: Iac61ea1017b14e0ad3c4425efc3d75718b71bb8e
      Signed-off-by: default avatarShawn O. Pearce <sop@google.com>
      3f8fdc03
    • Shawn Pearce's avatar
      Implement multi_ack_detailed protocol extension · a22b8f5f
      Shawn Pearce authored
      
      The multi_ack_detailed extension breaks out the "ACK %s continue" status
      code into "ACK %s common" and "ACK %s ready" states, making it easier to
      discover which objects are truely common, and which objects are simply
      on a chain the server doesn't care learning about.
      
      Change-Id: Ie8e907424cfbbba84996ca205d49eacf339f9d04
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      a22b8f5f
    • Shawn Pearce's avatar
      Abstract out utility functions for creating test commits · f945c424
      Shawn Pearce authored
      
      These routines create a fairly clean DSL for writing out the
      structure of a repository in a test case.  Abstract them into
      a helper class that we can reuse in other test environments.
      
      Change-Id: I55cce3d557e1a28afe2fdf37b3a5b67e2651c9f1
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      f945c424
    • Shawn Pearce's avatar
      Fix PersonIdent to always use SystemReader · 23cb7f9d
      Shawn Pearce authored
      
      Under unit tests we want the when and timezone to come from the
      MockSystemReader and be stable.  We did this for the default
      constructor based on the Repository, but failed to do it for the
      name,emailAddress variant of the constructor.
      
      Change-Id: I608ac7cf01673729303395e19b379b38fef136b3
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      23cb7f9d
    • Shawn Pearce's avatar
      Fix RefWriter creation of info/refs to omit HEAD · de45869e
      Shawn Pearce authored
      
      We really mean to omit HEAD here, but botched the difference between
      getOrigName and getName on the Ref object.  We tested on the wrong
      value, picking up the target of the symbolic ref and therefore
      included it twice.
      
      Change-Id: If780c65166ccada2e63a4f42bbab752a56b16564
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      de45869e
    • Shawn Pearce's avatar
      Move TestRng to our JUnit helper package · f88cac03
      Shawn Pearce authored
      
      Other test suites may find this useful, especially when trying
      to defeat the pack file compression with random data files.
      
      Change-Id: Ic00a4ac626af7a1c94d18ee99305e295b267b1a3
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      f88cac03
    • Shawn Pearce's avatar
      Correct spelling error in StringUtils javadoc · 15e2b45a
      Shawn Pearce authored
      
      Change-Id: Idd98530d5f6fca4de8631aa865e4bcd6e6cf9306
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      15e2b45a
    • Shawn Pearce's avatar
      Finish removing Apache Felix maven-bundle-plugin · 20b4d474
      Shawn Pearce authored
      
      Since Robin reverted using the maven-bundle-plugin to produce the
      OSGi manifest, there is no reason for us to reference it from our
      build process anymore.
      
      Also, when Robin reverted the to the Eclipse way of doing things,
      we failed to update the ignore files to ignore our generated files
      but not ignore our tracked .classpath.
      
      Finally, we cannot delete the MANIFEST.MF file during a Maven build,
      as this is once again a source file.
      
      Change-Id: I53f77f2002cb4285f728968829560e835651e188
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      20b4d474
    • Robin Rosenberg's avatar
      Fix merge for "Partial revert "Switch build to Apache Felix maven-bundle-plugin"" · cbab08fb
      Robin Rosenberg authored
      
      There was a missing dependency.
      
      Change-Id: Ib7b9f05ee4c7c2bd7760ce44a7c2cd72759d514d
      Signed-off-by: default avatarRobin Rosenberg <robin.rosenberg@dewire.com>
      cbab08fb
    • Robin Rosenberg's avatar
  4. Jan 10, 2010
  5. Jan 07, 2010
  6. Jan 06, 2010
    • Shawn Pearce's avatar
      Remove unnecessary semicolon in MergeChunk · f5029446
      Shawn Pearce authored
      
      Change-Id: I5526edca9816b90f5df2d7f14f24f11d3f5d2ead
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      f5029446
    • Shawn Pearce's avatar
      Merge branch 'cq-diff' · 1b4f76d7
      Shawn Pearce authored
      Per CQ 3559 "JGit - Eugene Myers O(ND) difference algorithm" we
      have approval to check this into our master branch.
      
      * cq-diff:
        Add file content merge algorithm
        Add performance tests for MyersDiff
        Add javadoc comments, remove unused code, shift comments to correct place
        Fixed MyersDiff to be able to handle more than 100k
        Fix some warnings regarding unnecessary imports and accessing static methods
        Add the "jgit diff" command
        Prepare RawText for diff-index and diff-files
        Add a test class for Myers' diff algorithm
        Add Myers' algorithm to generate diff scripts
        Add set to IntList
      
      Conflicts:
      	org.eclipse.jgit/src/org/eclipse/jgit/diff/RawText.java
      
      Change-Id: Ia8e98d81ba1ab52f84d0258a40e6ef5eece9a5b1
      CC: Christian Halstrick <christian.halstrick@sap.com>
      1b4f76d7
    • Christian Halstrick's avatar
      Add file content merge algorithm · 6d930cd5
      Christian Halstrick authored
      
      Adds the file content merge alorithm and tests for merge to jgit.
      The merge algorithm:
      
      - Gets as input parameters the common base, the two new contents
        called "ours" and "theirs".
      
      - Computes the Edits from base to ours and from base to theirs with
        the help of MyersDiff.
      
      - Iterates over the edits.
      
      - Independent edits from ours or from theirs will just be applied
        to the result.
      
      - For conflicting edits we first harmonize the ranges of the edits
        so that in the end we have exactly two edits starting and ending
        at the same points in the common base. Then we write the two
        conclicting contents into the result stream.
      
      Change-Id: I411862393e7bf416b6f33ca55ec5af608ff4663
      Signed-off-by: default avatarChristian Halstrick <christian.halstrick@sap.com>
      [sp: Fixed up two awkard comments in documentation.]
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      6d930cd5
  7. Jan 05, 2010
  8. Jan 04, 2010
  9. Dec 29, 2009
  10. Dec 28, 2009
    • Shawn Pearce's avatar
      Switch build to Apache Felix maven-bundle-plugin · fc5fc70e
      Shawn Pearce authored
      
      Tycho isn't production ready for projects like JGit to be using as
      their primary build driver.  Some problems we ran into with Tycho
      0.6.0 that are preventing us from using it are:
      
       * Tycho can't run offline
      
         The P2 artifact resolver cannot perform its work offline.  If the
         build system has no network connection, it cannot compile a
         project through Tycho.  This is insane for a distributed version
         control system where developers are used to being offline during
         development and local testing.
      
       * Magic state in ~/.m2/repository/.meta/p2-metadata.properties
      
         Earlier iterations of this patch tried to use a hybrid build,
         where Tycho was only used for the Eclipse specific feature and P2
         update site, and maven-bundle-plugin was used for the other code.
         This build seemed to work, but only due to magic Tycho specific
         state held in my local home directory.  This means builds are not
         consistently repeatable across systems, and lead me to believe
         I had a valid build, when in fact I did not.
      
       * Manifest-first build produces incomplete POMs
      
         The POM created by the manifest-first build format does not
         contain the dependency chain, leading a downstream consumer to
         not import the runtime dependencies necessary to execute the
         bundle it has imported.  In JGit's case, this means JSch isn't
         included in our dependency chain.
      
       * Manifest-first build produces POMs unreadable by Maven 2.x
      
         JGit has existing application consumers who are relying on
         Maven 2.x builds.  Forcing them to step up to an alpha release
         of Maven 3 is simply unacceptable.
      
       * OSGi bundle export data management is tedious
      
         Editing each of our pom.xml files to mark a new release is
         difficult enough as it is.  Editing every MANIFEST.MF file to
         list our exported packages and their current version number is
         something a machine should do, not a human.  Yet the Tycho OSGi
         way unfortunately demands that a human do this work.
      
       * OSGi bundle import data management is tedious
      
         There isn't a way in the MANIFEST.MF file format to reuse the
         same version tags across all of our imports, but we want to have
         a consistent view of our dependencies when we compile JGit.
      
      After wasting more than 2 full days trying to get Tycho to work,
      I've decided its a lost cause right now.  We need to be chasing down
      bugs and critical features, not trying to bridge the gap between
      the stable Maven repository format and the undocumented P2 format
      used only by Eclipse.
      
      So, switch the build to use Apache Felix's maven-bundle-plugin.
      
      This is the same plugin Jetty uses to produce their OSGi bundle
      manifests, and is the same plugin used by the Apache Felix project,
      which is an open-source OSGi runtime.  It has a reasonable number
      of folks using it for production builds, and is running on top of
      the stable Maven 2.x code base.
      
      With this switch we get automatically generated MANIFEST.MF files
      based on reasonably sane default rules, which reduces the amount
      of things we have to maintain by hand.  When necessary, we can add
      a few lines of XML to our POMs to tweak the output.
      
      Our build artifacts are still fully compatible with Maven 2.x, so
      any downstream consumers are still able to use our build products,
      without stepping up to Maven 3.x.  Our artifacts are also valid as
      OSGi bundles, provided they are organized on disk into a repository
      that the runtime can read.
      
      With maven-bundle-plugin the build runs offline, as much as Maven
      2.x is able to run offline anyway, so we're able to return to a
      distributed development environment again.
      
      By generating MANIFEST.MF at the top level of each project (and
      therefore outside of the target directory), we're still compatible
      with Eclipse's PDE tooling.  Our projects can be imported as standard
      Maven projects using the m2eclipse plugin, but the PDE will think
      they are vaild plugins and make them available for plugin builds,
      or while debugging another workbench.
      
      This change also completely removes Tycho from the build.
      
      Unfortunately, Tycho 0.6.0's pom-first dependency resolver is broken
      when resolving a pom-first plugin bundle through a manifest-first
      feature package, so bundle org.eclipse.jgit can't be resolved,
      even though it might actually exist in the local Maven repository.
      
      Rather than fight with Tycho any further, I'm just declaring it
      plugina-non-grata and ripping it out of the build.
      
      Since there are very few tools to build a P2 format repository, and
      no documentation on how to create one without running the Eclipse
      UI manually by poking buttons, I'm declaring that we are not going
      to produce a P2 update site from our automated builds.
      
      Change-Id: If7938a86fb0cc8e25099028d832dbd38110b9124
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      fc5fc70e
    • Robin Rosenberg's avatar
      Recognize Git repository environment variables · eb63bfc1
      Robin Rosenberg authored
      
      This makes the jgit command line behave like the C Git implementation
      in the respect.
      
      These variables are not recognized in the core, though we add support
      to do the overrides there. Hence other users of the JGit library, like
      the Eclipse plugin and others, will not be affected.
      
      GIT_DIR
      	The location of the ".git" directory.
      
      GIT_WORK_TREE
      	The location of the work tree.
      
      GIT_INDEX_FILE
      	The location of the index file.
      
      GIT_CEILING_DIRECTORIES
      	A colon (semicolon on Windows) separated list of paths that
      	which JGit will not cross when looking for the .git directory.
      
      GIT_OBJECT_DIRECTORY
      	The location of the objects directory under which objects are
      	stored.
      
      GIT_ALTERNATE_OBJECT_DIRECTORIES
      	A colon (semicolon on Windows) separated list of object directories
      	to search for objects.
      
      In addition to these we support the core.worktree config setting when
      the git directory is set deliberately instead of being found.
      
      Change-Id: I2b9bceb13c0f66b25e9e3cefd2e01534a286e04c
      Signed-off-by: default avatarRobin Rosenberg <robin.rosenberg@dewire.com>
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      eb63bfc1
    • Robin Rosenberg's avatar
      Add support for creating detached heads · 5b13adce
      Robin Rosenberg authored
      
      An extra flag when creating a RefUpdate object allows the
      caller to destroy the symref and replace it with an object
      ref, a.k.a. detached HEAD.
      
      Change-Id: Ia88d48eab1eb4861ebfa39e3be9258c3824a19db
      Signed-off-by: default avatarRobin Rosenberg <robin.rosenberg@dewire.com>
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      5b13adce
    • Shawn Pearce's avatar
      Use Constants.OBJECT_ID_STRING_LENGTH instead of LEN * 2 · 1ec393e7
      Shawn Pearce authored
      
      A few locations were doing OBJECT_ID_LENGTH * 2 on their own, as
      the old STR_LEN constant wasn't visible.  Replace them with the
      new public constant OBJECT_ID_STRING_LENGTH.
      
      Change-Id: Id39bddb52de8c65bb097de042e9d4ed99598201f
      Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
      1ec393e7
Loading