Skip to content
Snippets Groups Projects
Commit efdcb16b authored by Shawn Pearce's avatar Shawn Pearce
Browse files

Remove pointless boolean during native push


The boolean field sentCommand is always true at this point, as it
was assigned just 5 lines above.  So we always set the status of
the update command object to AWAITING_REPORT.

Simplify the logic by dropping the ?: operator.  I assume this is
older code from an attempt to manage dry-run push support within
the native connection, but in fact dry-run support is done higher
up inside of PushProcess.

Change-Id: I450d491bbbb5afecdbf5444ab7169222e856a3bb
Signed-off-by: default avatarShawn O. Pearce <spearce@spearce.org>
parent 3dd06704
No related branches found
No related tags found
No related merge requests found
......@@ -178,7 +178,7 @@ private void writeCommands(final Collection<RemoteRefUpdate> refUpdates,
}
pckOut.writeString(sb.toString());
rru.setStatus(sentCommand ? Status.AWAITING_REPORT : Status.OK);
rru.setStatus(Status.AWAITING_REPORT);
if (!rru.isDelete())
writePack = true;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment