Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
jgit
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Operate
Environments
Terraform modules
Monitor
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Faculty of Technology
Software Engineering
tools
cms
jgit
Commits
e7c9db83
Commit
e7c9db83
authored
14 years ago
by
Robin Rosenberg
Browse files
Options
Downloads
Patches
Plain Diff
Make sure a Stream is closed upon errors in IpLogGenerator
Signed-off-by:
Robin Rosenberg
<
robin.rosenberg@dewire.com
>
parent
f396326e
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogGenerator.java
+32
-28
32 additions, 28 deletions
...jgit.iplog/src/org/eclipse/jgit/iplog/IpLogGenerator.java
with
32 additions
and
28 deletions
org.eclipse.jgit.iplog/src/org/eclipse/jgit/iplog/IpLogGenerator.java
+
32
−
28
View file @
e7c9db83
...
@@ -236,36 +236,40 @@ private void loadCommitters(Repository repo) throws IOException {
...
@@ -236,36 +236,40 @@ private void loadCommitters(Repository repo) throws IOException {
SimpleDateFormat
dt
=
new
SimpleDateFormat
(
"yyyy-MM-dd HH:mm:ss"
);
SimpleDateFormat
dt
=
new
SimpleDateFormat
(
"yyyy-MM-dd HH:mm:ss"
);
File
list
=
new
File
(
repo
.
getDirectory
(),
"gerrit_committers"
);
File
list
=
new
File
(
repo
.
getDirectory
(),
"gerrit_committers"
);
BufferedReader
br
=
new
BufferedReader
(
new
FileReader
(
list
));
BufferedReader
br
=
new
BufferedReader
(
new
FileReader
(
list
));
String
line
;
try
{
String
line
;
while
((
line
=
br
.
readLine
())
!=
null
)
{
String
[]
field
=
line
.
trim
().
split
(
" *\\| *"
);
while
((
line
=
br
.
readLine
())
!=
null
)
{
String
user
=
field
[
1
];
String
[]
field
=
line
.
trim
().
split
(
" *\\| *"
);
String
name
=
field
[
2
];
String
user
=
field
[
1
];
String
email
=
field
[
3
];
String
name
=
field
[
2
];
Date
begin
=
parseDate
(
dt
,
field
[
4
]);
String
email
=
field
[
3
];
Date
end
=
parseDate
(
dt
,
field
[
5
]);
Date
begin
=
parseDate
(
dt
,
field
[
4
]);
Date
end
=
parseDate
(
dt
,
field
[
5
]);
if
(
user
.
startsWith
(
"username:"
))
user
=
user
.
substring
(
"username:"
.
length
());
if
(
user
.
startsWith
(
"username:"
))
user
=
user
.
substring
(
"username:"
.
length
());
Committer
who
=
committersById
.
get
(
user
);
if
(
who
==
null
)
{
Committer
who
=
committersById
.
get
(
user
);
who
=
new
Committer
(
user
);
if
(
who
==
null
)
{
int
sp
=
name
.
indexOf
(
' '
);
who
=
new
Committer
(
user
);
if
(
0
<
sp
)
{
int
sp
=
name
.
indexOf
(
' '
);
who
.
setFirstName
(
name
.
substring
(
0
,
sp
).
trim
());
if
(
0
<
sp
)
{
who
.
setLastName
(
name
.
substring
(
sp
+
1
).
trim
());
who
.
setFirstName
(
name
.
substring
(
0
,
sp
).
trim
());
}
else
{
who
.
setLastName
(
name
.
substring
(
sp
+
1
).
trim
());
who
.
setFirstName
(
name
);
}
else
{
who
.
setLastName
(
null
);
who
.
setFirstName
(
name
);
who
.
setLastName
(
null
);
}
committersById
.
put
(
who
.
getID
(),
who
);
}
}
committersById
.
put
(
who
.
getID
(),
who
);
}
who
.
addEmailAddress
(
email
);
who
.
addEmailAddress
(
email
);
who
.
addActiveRange
(
new
ActiveRange
(
begin
,
end
));
who
.
addActiveRange
(
new
ActiveRange
(
begin
,
end
));
committersByEmail
.
put
(
email
,
who
);
committersByEmail
.
put
(
email
,
who
);
}
}
finally
{
br
.
close
();
}
}
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment