Skip to content
Snippets Groups Projects
Commit e7c9db83 authored by Robin Rosenberg's avatar Robin Rosenberg
Browse files

Make sure a Stream is closed upon errors in IpLogGenerator

parent f396326e
No related branches found
No related tags found
No related merge requests found
...@@ -236,36 +236,40 @@ private void loadCommitters(Repository repo) throws IOException { ...@@ -236,36 +236,40 @@ private void loadCommitters(Repository repo) throws IOException {
SimpleDateFormat dt = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); SimpleDateFormat dt = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
File list = new File(repo.getDirectory(), "gerrit_committers"); File list = new File(repo.getDirectory(), "gerrit_committers");
BufferedReader br = new BufferedReader(new FileReader(list)); BufferedReader br = new BufferedReader(new FileReader(list));
String line; try {
String line;
while ((line = br.readLine()) != null) {
String[] field = line.trim().split(" *\\| *"); while ((line = br.readLine()) != null) {
String user = field[1]; String[] field = line.trim().split(" *\\| *");
String name = field[2]; String user = field[1];
String email = field[3]; String name = field[2];
Date begin = parseDate(dt, field[4]); String email = field[3];
Date end = parseDate(dt, field[5]); Date begin = parseDate(dt, field[4]);
Date end = parseDate(dt, field[5]);
if (user.startsWith("username:"))
user = user.substring("username:".length()); if (user.startsWith("username:"))
user = user.substring("username:".length());
Committer who = committersById.get(user);
if (who == null) { Committer who = committersById.get(user);
who = new Committer(user); if (who == null) {
int sp = name.indexOf(' '); who = new Committer(user);
if (0 < sp) { int sp = name.indexOf(' ');
who.setFirstName(name.substring(0, sp).trim()); if (0 < sp) {
who.setLastName(name.substring(sp + 1).trim()); who.setFirstName(name.substring(0, sp).trim());
} else { who.setLastName(name.substring(sp + 1).trim());
who.setFirstName(name); } else {
who.setLastName(null); who.setFirstName(name);
who.setLastName(null);
}
committersById.put(who.getID(), who);
} }
committersById.put(who.getID(), who);
}
who.addEmailAddress(email); who.addEmailAddress(email);
who.addActiveRange(new ActiveRange(begin, end)); who.addActiveRange(new ActiveRange(begin, end));
committersByEmail.put(email, who); committersByEmail.put(email, who);
}
} finally {
br.close();
} }
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment