Skip to content
Snippets Groups Projects
Commit e5df4e0d authored by Nicolas Pope's avatar Nicolas Pope
Browse files

Merge branch 'bug/#41' into 'main'

#41 Fix missing destructor virtual

See merge request nicolaspope/beyond-protocol!12
parents 80889666 fb7d781e
No related branches found
No related tags found
No related merge requests found
......@@ -16,6 +16,8 @@ namespace ftl {
struct Handle;
struct BaseHandler {
virtual ~BaseHandler() {}
virtual void remove(const Handle &) = 0;
virtual void removeUnsafe(const Handle &) = 0;
......@@ -97,7 +99,7 @@ struct [[nodiscard]] Handle {
template <typename ...ARGS>
struct Handler : BaseHandler {
Handler() {}
~Handler() {
virtual ~Handler() {
// Ensure all thread pool jobs are done
while (jobs_ > 0 && ftl::pool.size() > 0) std::this_thread::sleep_for(std::chrono::milliseconds(2));
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment