From aaf18a2974d55bb9d0c83ce97e97e1439ff27dc2 Mon Sep 17 00:00:00 2001
From: Robin Stocker <robin@nibor.org>
Date: Tue, 6 Feb 2024 12:58:30 +1100
Subject: [PATCH] Use tight blocks to render tables
---
.../tables/internal/TableMarkdownNodeRenderer.java | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/commonmark-ext-gfm-tables/src/main/java/org/commonmark/ext/gfm/tables/internal/TableMarkdownNodeRenderer.java b/commonmark-ext-gfm-tables/src/main/java/org/commonmark/ext/gfm/tables/internal/TableMarkdownNodeRenderer.java
index bf94db5b..48714716 100644
--- a/commonmark-ext-gfm-tables/src/main/java/org/commonmark/ext/gfm/tables/internal/TableMarkdownNodeRenderer.java
+++ b/commonmark-ext-gfm-tables/src/main/java/org/commonmark/ext/gfm/tables/internal/TableMarkdownNodeRenderer.java
@@ -30,15 +30,15 @@ public class TableMarkdownNodeRenderer extends TableNodeRenderer implements Node
@Override
protected void renderBlock(TableBlock node) {
columns.clear();
+ writer.pushTight(true);
renderChildren(node);
+ writer.popTight();
writer.block();
}
@Override
protected void renderHead(TableHead node) {
renderChildren(node);
- // TODO: Not sure about this.. Should block() detect if a line was already written? Or should line() itself be lazy?
- writer.line();
for (TableCell.Alignment columnAlignment : columns) {
writer.raw('|');
if (columnAlignment == TableCell.Alignment.LEFT) {
@@ -52,10 +52,7 @@ public class TableMarkdownNodeRenderer extends TableNodeRenderer implements Node
}
}
writer.raw("|");
- // TODO
- if (node.getNext() != null) {
- writer.line();
- }
+ writer.block();
}
@Override
@@ -68,10 +65,7 @@ public class TableMarkdownNodeRenderer extends TableNodeRenderer implements Node
renderChildren(node);
// Trailing | at the end of the line
writer.raw("|");
- // TODO
- if (node.getNext() != null) {
- writer.line();
- }
+ writer.block();
}
@Override
--
GitLab