From fb7d781e65ef04cc0619775baf0ea8a39010c392 Mon Sep 17 00:00:00 2001
From: Nicolas Pope <nicolas.pope@utu.fi>
Date: Wed, 18 May 2022 14:02:20 +0000
Subject: [PATCH] #41 Fix missing destructor virtual
---
include/ftl/handle.hpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/ftl/handle.hpp b/include/ftl/handle.hpp
index 0744c91..57aeb16 100644
--- a/include/ftl/handle.hpp
+++ b/include/ftl/handle.hpp
@@ -16,6 +16,8 @@ namespace ftl {
struct Handle;
struct BaseHandler {
+ virtual ~BaseHandler() {}
+
virtual void remove(const Handle &) = 0;
virtual void removeUnsafe(const Handle &) = 0;
@@ -97,7 +99,7 @@ struct [[nodiscard]] Handle {
template <typename ...ARGS>
struct Handler : BaseHandler {
Handler() {}
- ~Handler() {
+ virtual ~Handler() {
// Ensure all thread pool jobs are done
while (jobs_ > 0 && ftl::pool.size() > 0) std::this_thread::sleep_for(std::chrono::milliseconds(2));
}
--
GitLab